Convert hui-divider-row to TypeScript/LitElement #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This is currently broken. It doesn't like how I am applying the style to the div using JS, takes it as an object |
balloob
reviewed
Oct 28, 2018
| } | ||
|
|
||
| return html` | ||
| ${this._createDivider()} |
There was a problem hiding this comment.
I couldn't figure out how to apply the passed into styles to the div without using setProperty 🤷♂️
There was a problem hiding this comment.
So then you can still just copy the content of createDivider into render and then do:
return html`${el}`;
balloob
approved these changes
Oct 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.