Convert hui-weblink-row to TypeScript/LitElement #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Oct 28, 2018
| } | ||
|
|
||
| public setConfig(config): void { | ||
| if (!config || !config.icon || !config.name || !config.url) { |
There was a problem hiding this comment.
I wonder why we make icon mandatory, can't we default to one?
Same with name, if no name, use url?
There was a problem hiding this comment.
Also, we should add a type for this config.
* Made name and icon fields optional. Will create a corresponding PR to the docs to update them as Optional * Updated entities-card to not check weblink config as that is the job of the element (entities-card should be updated to not check service-call config either as that is the job of the row element as well)
iantrich
added a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Oct 28, 2018
This will coincide with home-assistant/frontend#1898
2 tasks
balloob
reviewed
Oct 28, 2018
| throw new Error("Invalid Configuration: 'url' required"); | ||
| } | ||
|
|
||
| config.icon = config.icon || "hass:link"; |
There was a problem hiding this comment.
We should never change the passed in value. Instead do this:
this._config = {
icon: 'hass:link',
name: config.url,
...config
}That's cool!
balloob
approved these changes
Oct 28, 2018
frenck
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Oct 29, 2018
* weblink parameters `name` and `icon` optional This will coincide with home-assistant/frontend#1898 * 🚑 Fixes build error
zsarnett
pushed a commit
to zsarnett/home-assistant.io
that referenced
this pull request
Oct 30, 2018
* weblink parameters `name` and `icon` optional This will coincide with home-assistant/frontend#1898 * 🚑 Fixes build error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.