Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove side effects of render and Add types - Button/Glance #1919

Merged
merged 6 commits into from
Nov 2, 2018
Merged

Remove side effects of render and Add types - Button/Glance #1919

merged 6 commits into from
Nov 2, 2018

Conversation

zsarnett
Copy link
Contributor

This adds types to parameters and return values for each function and moves the theme applying to updated function

@ghost ghost assigned zsarnett Oct 29, 2018
@ghost ghost added the in progress label Oct 29, 2018
balloob
balloob approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, can be merged once the last few things have been addressed

@zsarnett
Copy link
Contributor Author

zsarnett commented Nov 2, 2018 •
edited
Loading

@balloob It was complaining about HassEntityBase - So I switch it to HAssEntity. Not sure if this is correct

@balloob
Copy link
Member

balloob commented Nov 2, 2018

Yeah that's ok.

@balloob balloob merged commit aebd1a1 into dev Nov 2, 2018
@balloob balloob deleted the theme-updates branch November 2, 2018 09:13
@ghost ghost removed the in progress label Nov 2, 2018
@balloob balloob mentioned this pull request Nov 3, 2018
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees

@zsarnett zsarnett

Labels
cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsarnett @balloob @cgarwood @homeassistant