Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional card with undefined hass #1927

Merged
merged 3 commits into from
Oct 30, 2018
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 30, 2018

This fixes conditional card cards triggering "hass" or "states" undefined errors.

Fixes #1905
Replaces #1906

@balloob balloob merged commit a771a44 into dev Oct 30, 2018
@ghost ghost removed the in progress label Oct 30, 2018
@balloob balloob deleted the fix-conditional-hass-undefined branch October 30, 2018 10:31
@balloob
Copy link
Member Author

balloob commented Oct 30, 2018

Merging it because going to push a new frontend to dev

@zsarnett zsarnett added this to the 0.81.3 milestone Oct 31, 2018
balloob added a commit that referenced this pull request Nov 2, 2018
* Fix conditional card with undefined hass

* Conditional appendChild

* Allow updating card properly
@LukaszP2
Copy link

@bramkragten
Copy link
Member

Don't respond to closed pull requests. If you think there is an issue create an issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media-control in conditional card still broken in 0.81.1
6 participants