Catch translation errors #1928
Merged
Catch translation errors #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
balloob
reviewed
Oct 30, 2018
| try { | ||
| return translatedMessage.format(argObject); | ||
| } catch (err) { | ||
| return "Translation " + err; |
There was a problem hiding this comment.
What kind of errors would this generate ? And how would that look in the UI?
There was a problem hiding this comment.
There was a problem hiding this comment.
It ain't pretty, but better than not showing anything at all, and it is an error after all... (we might make it red)
There was a problem hiding this comment.
We can't make it red as we only can return strings.
I guess it's fine.
There was a problem hiding this comment.
Also someone stop that Dutch translator …
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer fails the entire page when a placeholder is translated, or translation fails.
Fixes: #1917