Fix MFA module name not showing on step completion #19581
Conversation
| @@ -97,7 +97,7 @@ class HaMfaModuleSetupFlow extends LitElement { | |||
| ? html`<p> | |||
| ${this.hass.localize( | |||
| "ui.panel.profile.mfa_setup.step_done", | |||
| { step: this._step.title } | |||
| { step: this._step!.handler } | |||
There was a problem hiding this comment.
handler is a technical key, why don't we get title anymore? I don't think this is the right fix.
There was a problem hiding this comment.
This should probably just be handled by translations?
this.hass.localize(
`component.auth.mfa_setup.${
this._step!.handler
}.step.${
(this._step! as DataEntryFlowStepForm).step_id
}.description`,
this._step!.description_placeholders
)There was a problem hiding this comment.
I agree with both your comments here. I spent entirely too long longer at this before eventually throwing in the towel and going with this approach, if not just to get a second opinion.
It looks like this was working (from looking at some YouTube videos) in 2018 and was then broken at some point in the years gone by - unnoticed - probably when there was an architecture change.
I thought too that we could probably, for now, safely just refer to a single translation as there is only one method.
Then, I found out that “Authenticator app” is hardcoded somewhere deep in the code (not translated)...
On your second point. This all started with me simply trying to take {qr_code} and wrap it with {url} to get a clickable method of enrolling MFA.
Don’t know if you’ve ever tried scanning a QR on mobile from your own screen (hint: it’s physically impossible, without another device).
With the current approach, I wasn’t able to get there :(
There was a problem hiding this comment.
Don’t know if you’ve ever tried scanning a QR on mobile from your own screen (hint: it’s physically impossible, without another device).
I always make a screenshot and then run the image through a QR scanner 🙃
There was a problem hiding this comment.
I'll check what is available and what was changed soon
There was a problem hiding this comment.
Just checked and this is working.
Proposed change
MFA module name is not showing on step completion resulting in an incomplete and potentially confusing sententence. Videos from three years ago show the message showing "Setup done for Authenticator app". Today, it simply shows "Setup done for".
Type of change
Example configuration
Final step does not show the module configured and so the sentence is incomplete.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: