Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly prompt for lock code in dashboards #19835

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

chammp
Copy link
Contributor

@chammp chammp commented Feb 19, 2024

Proposed change

Currently, a lock with a code_format is unusable from a dashboard row when no default code is set. When clicking on "unlock" or "lock" button, only an error toast message is displayed reading "The code for lock.test_with_code doesn't match pattern ...". Only when (un)locking from the entity info dialog, the code prompt is opened.

After this PR, the prompt is displayed in more places where a lock is displayed with its default entity card.

Before:

grafik

After:

grafik

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@chammp chammp changed the title Always prompt for lock code in dashboards Directly prompt for lock code in dashboards Feb 19, 2024
@chammp chammp marked this pull request as ready for review February 19, 2024 19:04
@bramkragten bramkragten merged commit e8fca5d into home-assistant:dev Feb 26, 2024
14 checks passed
@chammp chammp deleted the always_prompt_for_lock_codes branch February 26, 2024 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants