Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate cardSize for Tile card #19853

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Feb 21, 2024

Proposed change

Tile card cardSize function currently just returns 1 (50px). It would be more accurate to take into account the configuration, which might make the card more like 2-4 units in height.

The proposed function seems to map pretty well to units of height, as adding vertical or a feature control adds pretty close to 50px in height each.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya
Copy link
Member

piitaya commented Feb 21, 2024

Thanks @karwosts!

@piitaya piitaya merged commit a26df88 into home-assistant:dev Feb 21, 2024
15 checks passed
@karwosts karwosts deleted the tile-cardsize branch February 21, 2024 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants