Disable beta menu instead of hiding #20906
Conversation
balloob
changed the title
WalkthroughWalkthroughThis update modifies the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant HaConfigSectionUpdates
participant Supervisor
User->>HaConfigSectionUpdates: Access Configuration Section
HaConfigSectionUpdates->>Supervisor: Fetch Supervisor Info
Supervisor-->>HaConfigSectionUpdates: Return Channel Info
alt Channel is "dev"
HaConfigSectionUpdates-->>User: Display Disabled List Item
else Channel is not "dev"
HaConfigSectionUpdates-->>User: Display Enabled List Item
end
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedBiome (6)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range comments (3)
src/panels/config/core/ha-config-section-updates.ts (3)
Line range hint
147-147: Avoid using non-null assertions.Using non-null assertions can lead to runtime errors if the object is null. Consider adding proper checks or handling potential null values gracefully.
Line range hint
165-165: Specify a more specific type thanany.Using
anytype defeats the purpose of TypeScript's static type checking. Try to specify a more accurate type for the error object to enhance code robustness and maintainability.
Line range hint
1-1: Optimize import statements.Consider using TypeScript's
import typesyntax for imports that are only used for type annotations. This can help clarify the intent and potentially optimize the bundling process.- import { RequestSelectedDetail } from "@material/mwc-list/mwc-list-item"; + import type { RequestSelectedDetail } from "@material/mwc-list/mwc-list-item"; - import { mdiDotsVertical, mdiRefresh } from "@mdi/js"; + import type { mdiDotsVertical, mdiRefresh } from "@mdi/js"; - import { HassEntities } from "home-assistant-js-websocket"; + import type { HassEntities } from "home-assistant-js-websocket"; - import { LitElement, TemplateResult, css, html } from "lit"; + import type { LitElement, TemplateResult, css, html } from "lit"; - import { customElement, property, state } from "lit/decorators"; + import type { customElement, property, state } from "lit/decorators"; - import memoizeOne from "memoize-one"; + import type memoizeOne from "memoize-one"; - import { isComponentLoaded } from "../../../common/config/is_component_loaded"; + import type { isComponentLoaded } from "../../../common/config/is_component_loaded"; - import { shouldHandleRequestSelectedEvent } from "../../../common/mwc/handle-request-selected-event"; + import type { shouldHandleRequestSelectedEvent } from "../../../common/mwc/handle-request-selected-event";Also applies to: 2-3, 3-4, 15-22
|
Some alternatives:
|
I like the idea to pick the release channel, regardless of which release you're on. To be consistent this would mean you can select all: stable, beta and nightly. Question is, does bringing nightly to the UI give enough benefit compared to the effort? For example, I assume that if we add nightly as an option in the UI, it would cause some support load. If we add it, I would suggest in changing the labels in the UI to:
|
|
I agree for leaving nightly to beta to stable using the UI but I'm not sure to join nightly using UI. As @matthiasdebaat said, it's only for dev so cli is not an issue. |
|
I agree, it shouldnt be too easy to join nightly. |
Breaking change
Proposed change
So, I was on nightly and couldn't find the beta menu when someone asked me where it was. Realized it was hidden when you're on nightly.
To avoid confusion, I think it's better to disable it so users can still know where it is.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit