Clean up OHF badge for splash screen #21593

Madelena · 2024-08-06T00:26:15Z

Breaking change

Proposed change

The splash screen looks better now:

HA logo is now vertically centered.
OHF badge looks closer to the common badges for OHF libraries.
Better padding for the OHF badge and the text.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue or discussion:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

New Features
- Enhanced launch screen styling for improved visual presentation.
- Added responsiveness with a media query for dark mode compatibility.
- Updated logo image source and increased its height for better visibility.
Bug Fixes
- Adjusted margins and padding to refine element spacing and positioning on the launch screen.

home-assistant

Hi @Madelena

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2024-08-06T00:26:19Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

coderabbitai · 2024-08-06T00:26:24Z

Warning

Rate limit exceeded

@Madelena has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 59 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between cc01d77 and 862cbdd.

Walkthrough

The recent changes enhance the HTML template for the launch screen by refining its styling and structure. Key updates include adjustments to the logo's margins, opacity, and the introduction of a media query for dark mode compatibility. Spacing optimizations and improvements to the logo image source and dimensions contribute to a more polished and responsive user interface, ensuring better visibility and alignment with user preferences across various display settings.

Changes

Files	Change Summary
`src/html/index.html.template`	Adjusted styles for the launch screen, including new padding and margin values, changes to logo opacity, and the addition of a media query for dark mode. The logo image source was updated for better branding, and its height was increased for improved visibility.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LaunchScreen
    participant Logo

    User->>LaunchScreen: Open application
    LaunchScreen->>Logo: Load logo image
    Logo-->>LaunchScreen: Display logo
    LaunchScreen->>User: Render launch screen
    User->>LaunchScreen: Switch to dark mode
    LaunchScreen->>Logo: Apply invert filter
    Logo-->>LaunchScreen: Update logo appearance
    LaunchScreen->>User: Show updated launch screen

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Stale

bramkragten · 2024-08-06T12:58:53Z

demo/src/html/index.html.template

      }
    </style>
  </head>
  <body>
    <div id="ha-launch-screen">
-      <div class="ha-launch-screen-spacer"></div>
+      <div class="ha-launch-screen-spacer" style="margin-top: 142px;"></div>


please move the inline style to the style block

bramkragten · 2024-08-06T13:04:35Z

demo/src/html/index.html.template

-        color: grey;
-        font-size: 12px;
-        margin-bottom: 16px;
+        margin: 48px 0;


margin-bottom: max(env(safe-area-inset-bottom), 48px);

Clean up OHF badge for splash screen

2d7589b

home-assistant bot previously requested changes Aug 6, 2024

View reviewed changes

home-assistant bot added the cla-needed label Aug 6, 2024

home-assistant bot marked this pull request as draft August 6, 2024 00:26

github-actions bot added the Demo Related to frontend demo content label Aug 6, 2024

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Aug 6, 2024

Madelena marked this pull request as ready for review August 6, 2024 00:30

Fix demo logo size

7a8abfe

bramkragten reviewed Aug 6, 2024

View reviewed changes

Madelena added 3 commits August 6, 2024 17:10

Fixed the code to Bram's feedback

5521737

Merge branch 'dev' into dev

cc01d77

Pixel pushing

862cbdd

bgoncal approved these changes Aug 7, 2024

View reviewed changes

silamon approved these changes Aug 8, 2024

View reviewed changes

silamon merged commit f0f0aef into home-assistant:dev Aug 8, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up OHF badge for splash screen #21593

Clean up OHF badge for splash screen #21593

Madelena commented Aug 6, 2024 •

edited by coderabbitai bot

Loading

home-assistant bot left a comment

home-assistant bot commented Aug 6, 2024

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

bramkragten Aug 6, 2024

bramkragten Aug 6, 2024

Clean up OHF badge for splash screen #21593

Clean up OHF badge for splash screen #21593

Conversation

Madelena commented Aug 6, 2024 • edited by coderabbitai bot Loading

Breaking change

Proposed change

Type of change

Example configuration

Additional information

Checklist

Summary by CodeRabbit

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot commented Aug 6, 2024

coderabbitai bot commented Aug 6, 2024 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

bramkragten Aug 6, 2024

Choose a reason for hiding this comment

bramkragten Aug 6, 2024

Choose a reason for hiding this comment

Madelena commented Aug 6, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)