-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to delete add-on config on uninstall #22268
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
text: this.supervisor.localize("dialog.uninstall_addon.text"), | ||
text: html` | ||
<ha-formfield | ||
.label=${html`<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the p
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the p
a line appears on top of the text after it is clicked. Also the margins are too small without it. I could've added margins another way but saw this used somewhere else in the code
From an UX point of view, should it be two different dialog? Looks like we are now asking 2 questions are the same time : confirmation and data removal. |
I would prefer 1 dialog with the toggle in the more common state by default. Successive popups can be annoying |
Proposed change
When uninstalling an add-on, we should ask the user if they also want to delete the add-on data (similar to e.g., how one removes an app on iOS which will also prompt that question).
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: