-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show if a custom integration overwrites a core integration #22295
Conversation
44a31ae
to
9a6245c
Compare
I would really prefer to change the custom integration icon somehow, rather than add a new one because they become redundant. If it overwrites core, than it must be custom. |
I couldn't find a better icon so it could be combined. In the end you want this to stand out to let the user know that they have overridden the core integration. I'm not sure if "overwrites" is the correct term that explains it all, you've used overridden and my first thought would be to replace a core integration. |
We've decided to go with 1 icon and update the design of all the icons. This will only change the tooltip and color. The rest of the icon changes will be in a separate PR |
backend has been merged. |
The design used to implement changes: https://www.figma.com/design/zSpQQiJb0AEc6jRaKIkL5l/HA-03?node-id=0-1&t=3EL1cUmDRXaQVVcV-1 |
Proposed change
Sometimes users override a core integration, without them knowing they do. This often results in unexpected behavior.
While it is part of the design of core to allow for overriding core integration, we should make the user more aware they actually are override a core integration.
I do need some input on the design. Ideally I would've replaced the custom component icon with the same + an exclamation mark, but there isn't such an icon in Material icons. So the options I see are:Add a new icon. This is the current implementation in this PRChange the icon frompackage-variant
to something else but what?Change the color of the icon to something more prominent. The icons in the selector for a new integrations don't have color thoughThe design decision was to change the color and tooltip

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: