Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show if a custom integration overwrites a core integration #22295

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Oct 9, 2024

Proposed change

Sometimes users override a core integration, without them knowing they do. This often results in unexpected behavior.
While it is part of the design of core to allow for overriding core integration, we should make the user more aware they actually are override a core integration.

I do need some input on the design. Ideally I would've replaced the custom component icon with the same + an exclamation mark, but there isn't such an icon in Material icons. So the options I see are:

  • Add a new icon. This is the current implementation in this PR
  • Change the icon from package-variant to something else but what?
  • Change the color of the icon to something more prominent. The icons in the selector for a new integrations don't have color though

The design decision was to change the color and tooltip
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze
Copy link
Contributor Author

I would really prefer to change the custom integration icon somehow, rather than add a new one because they become redundant. If it overwrites core, than it must be custom.

@silamon
Copy link
Contributor

silamon commented Oct 11, 2024

I couldn't find a better icon so it could be combined. In the end you want this to stand out to let the user know that they have overridden the core integration.

I'm not sure if "overwrites" is the correct term that explains it all, you've used overridden and my first thought would be to replace a core integration.

@MindFreeze
Copy link
Contributor Author

We've decided to go with 1 icon and update the design of all the icons. This will only change the tooltip and color. The rest of the icon changes will be in a separate PR

@frenck
Copy link
Member

frenck commented Oct 16, 2024

backend has been merged.

@frenck frenck merged commit 82ec308 into home-assistant:dev Oct 16, 2024
15 checks passed
@MindFreeze MindFreeze deleted the custom_overwrite branch October 16, 2024 07:30
@marcinbauer85
Copy link
Contributor

marcinbauer85 commented Oct 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants