Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Thread border router instance name #22378

Merged

Conversation

agners
Copy link
Member

@agners agners commented Oct 15, 2024

Breaking change

Proposed change

Instead of using the model name (which is the same for all border routers of the same make and model), use the instance name as the border router name.

Builds on home-assistant/core#127253.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Instead of using the model name (which is the same for all border
routers of the same make and model), use the instance name as the
border router name.

Builds on home-assistant/core#127253.
@agners agners added the Feature PRs that are adding a new feature label Oct 15, 2024
@agners agners merged commit fca97cd into home-assistant:dev Oct 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Feature PRs that are adding a new feature hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants