Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore disabled entities to the statistics table #22411

Merged

Conversation

karwosts
Copy link
Contributor

Proposed change

I want to make a case for a revert of #10677, which I don't quite understand the reasoning for. This PR will remove the filter for disabled entities in the statistics table, causing them to again be shown (with a corresponding FIX ISSUE).

If user has a disabled entity, and it still has data recorded in the statistics table, I think the user would like the opportunity to be able to clean that up to minimize unnecessary data in the table. Currently once an entity is disabled, it's records now remain forever orphaned in the table and you can't delete them.

I asked Tom (author of the original issue that spawned the original PR), and he said he's fine with reverting it now that he understands that if he "fixes" the issue, the entity will go away from the table. I guess he originally thought all disabled entities would always appear in the table, which is not the case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 7a36cf6 into home-assistant:dev Oct 29, 2024
17 checks passed
@karwosts karwosts deleted the restored-disabled-statistics-table branch October 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants