-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use undo notification when deleting a card or badge #22414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2d1ac1
to
e66caaf
Compare
f8970cd
to
7bd9216
Compare
9 tasks
wendevlin
requested changes
Oct 22, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
31e9251
to
a9b4117
Compare
wendevlin
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can check if we can add the type import check into our linter.
Co-authored-by: Wendelin <12148533+wendevlin@users.noreply.github.com>
wendevlin
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use notification with undo button instead of confirm dialog when deleting a card or a badge.
This PR also fixes some issues with notifications manager :
showToast
method on the lovelace object.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: