Fix an infinite loop in automation numeric_state #22429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Address issues from #22403
As best I can tell what was happening was (on changing template field from empty to e.g.
a
)undefined
totrue/false
invalueChanged
, as well as firing avalueChanged
event with the new template condition.@state
.@state
change,template
field is still undefined because the valueChanged event hasn't propogated up and back down yet.""
. This seems unique to codemirror/template blocks, and is not how e.g. a text field behaves. not sure if that's an issue.""
, and fires another value-changed with template as""
.template: a
, and second one withtemplate: ""
.This is mitigated by setting the inputMode variables to true/false before the first time valueChanged event is received, so they don't trigger updates from unrelated change in other fields.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: