-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for update entity's update_percentage state attribute #22453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have backward compatibility or not? Entities that are not migrated yet to the new format will not have percentage.
I'm ok with that but I wanted to be sure. Otherwise, the PR is ok for me.
@piitaya there's no need for backwards compatibility in frontend to my understanding, the linked core
|
latest_version: string | null; | ||
release_summary: string | null; | ||
release_url: string | null; | ||
skipped_version: string | null; | ||
title: string | null; | ||
update_percentage: number | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this attribute always be around, even when not updating or not supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's how it's implemented in the core PR. If that's changed during the review of the core PR, this PR needs to be updated I think?
What is missing here is a change to the update screen in the voice assistant wizard, I'll add that tomorrow |
Proposed change
Add support for update entity's
update_percentage
state attributeBackend PR: home-assistant/core#128877
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: