Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old safari but for relative time #22457

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix old safari but for relative time #22457

merged 2 commits into from
Oct 22, 2024

Conversation

wendevlin
Copy link
Contributor

Proposed change

Older Safari browser (<= iOS 15) havn't been able to show the ha-relative-time because of a browser bug.
A datetime string needs to be "2024-10-21T15:27:00" but we provide it as "2024-10-21 15:27:00". date-fns.parseISO fix this issue for us.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin merged commit 11fc5bc into dev Oct 22, 2024
15 checks passed
@wendevlin wendevlin deleted the fix-relative-time-es5 branch October 22, 2024 10:25
piitaya pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants