Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-range-picker): select element is hard to read in dark mode #22479

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Cryolitia
Copy link
Contributor

@Cryolitia Cryolitia commented Oct 22, 2024

Proposed change

The select element's background is set to transparent while its color is the primary color. It makes users hard to read it, when the primary color is low saturation.

We can set the select element's backfround to the card's background to fix it.

It occurs on My Chrome 129.0.6668.89 on Linux, and this patch fixes it.

image

Firefox(on My Firefox 131.0.2 on Linux) doesn't care about this style at all, so it shouldn't affect Firefox.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

N/A

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Cryolitia

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Cryolitia Cryolitia marked this pull request as ready for review October 22, 2024 15:24
@piitaya piitaya merged commit 28e12f7 into home-assistant:dev Oct 29, 2024
19 checks passed
@Cryolitia Cryolitia deleted the patch-1 branch October 29, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants