add previous and next button to History and Logbook #22802

boern99 · 2024-11-12T22:57:18Z

Breaking change

Proposed change

add previous and next buttons to History and Logbook:

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue or discussion:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

coderabbitai · 2024-11-12T22:57:25Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

wendevlin

Thank you, really nice improvement.

I just made some comments.

Please set your git config name. Currently it is set to Your Name

src/components/ha-date-range-picker.ts

wendevlin · 2024-11-14T14:28:39Z

src/components/ha-date-range-picker.ts

+                <ha-icon-button-prev
+                  .label=${this.hass.localize("ui.common.previous")}
+                  class="prev"
+                  @click=${this._handlePrev}
+                >
+                </ha-icon-button-prev>


Please hide prev and next buttons on mobile, it takes too much space, look how it is done with ha-svg-icon

Maybe a stupid question, why is there a second Date-Entry for EndDate? Both: StartDate and Enddate load the exact same Daterange-Picker which includes Start and Enddate? Thought about to remove the EndDate for mobile.
If i disable the prev and next buttons they can not be used on small displays. Maybe I found another solution: changing the media-query solved it.

home-assistant · 2024-11-14T14:33:00Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

boern99 · 2024-11-14T17:30:03Z

src/components/ha-date-range-picker.ts

@@ -413,7 +456,7 @@ export class HaDateRangePicker extends LitElement {
        }
      }

-      @media only screen and (max-width: 500px) {
+      @media only screen and (max-width: 560px) {


Only had troubles on Resolutions between 500 and 560px.
I added 560 here, as min-width:inherit shrinks the date to fit ..

add previous and next button to History and Logbook

37cffe2

home-assistant bot added the cla-signed label Nov 12, 2024

bramkragten assigned wendevlin Nov 13, 2024

bramkragten added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Nov 13, 2024

Merge branch 'dev' into add-previous-and-next-buttons-to-history

16107b0

wendevlin requested changes Nov 14, 2024

View reviewed changes

home-assistant bot marked this pull request as draft November 14, 2024 14:33

used date-fns and changed media-query-resolution to fit on mobiles

9e62f60

boern99 marked this pull request as ready for review November 14, 2024 17:25

home-assistant bot requested a review from wendevlin November 14, 2024 17:25

boern99 commented Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add previous and next button to History and Logbook #22802

add previous and next button to History and Logbook #22802

boern99 commented Nov 12, 2024 •

edited

Loading

coderabbitai bot commented Nov 12, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

wendevlin left a comment

wendevlin Nov 14, 2024

boern99 Nov 14, 2024 •

edited

Loading

home-assistant bot commented Nov 14, 2024

boern99 Nov 14, 2024

add previous and next button to History and Logbook #22802

Are you sure you want to change the base?

add previous and next button to History and Logbook #22802

Conversation

boern99 commented Nov 12, 2024 • edited Loading

Breaking change

Proposed change

Type of change

Example configuration

Additional information

Checklist

coderabbitai bot commented Nov 12, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

wendevlin left a comment

Choose a reason for hiding this comment

wendevlin Nov 14, 2024

Choose a reason for hiding this comment

boern99 Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

home-assistant bot commented Nov 14, 2024

boern99 Nov 14, 2024

Choose a reason for hiding this comment

boern99 commented Nov 12, 2024 •

edited

Loading

coderabbitai bot commented Nov 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

boern99 Nov 14, 2024 •

edited

Loading