Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pair 'remove' with 'add' in description of To-do list card #23044

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Nov 28, 2024

When using 'Add' in Home Assistant this should always pair with 'Remove', like 'Create' does with 'Delete'.

The To-do list card introduces an inconsistent third word by using 'clear' instead, right next to 'add'.
This isn't used anywhere else in HA like in To-do list actions or the UI where it's always 'remove', even in the To-do list card itself:

image

This fixes this and also properly capitalizes "To-do list" as it's a name like in all other Dashboard card types.

Proposed change

Replace "to-do list' with 'To-do list' as it's a name.

Replace 'clear' with 'remove' for consistent wording.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

When using 'Add' in HA this should always pair with 'Remove', like 'Create' with 'Delete'.

The To-do list card introduces an inconsistent third word by using 'clear' instead of 'remove'.

This fixes this and also properly capitalizes "To-do list" as it's name like in all other Dashboard card types.
@MindFreeze MindFreeze added the localization Translations and Localization label Nov 29, 2024
@MindFreeze MindFreeze merged commit 9701578 into home-assistant:dev Nov 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed localization Translations and Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants