-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Media Browser view in localStorage #23061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂
key: "mediaBrowserPreferredLayout", | ||
storage: "localStorage", | ||
state: true, | ||
deserializer: (value) => value || "auto", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use deserializer
for this, just a normal initialiser should work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change
Proposed change
Media Browser remembers the selected view mode in localStorage, so the user doesn't need to re-select each session. I've seen it requested in a few places, including https://community.home-assistant.io/t/list-view-in-media-browser/248133/3. Just a tiny change.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: