Made it easier to test the frontend against an existing core instance. #23062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
MindFreeze
previously approved these changes
Dec 1, 2024
MindFreeze
approved these changes
Dec 2, 2024
|
Thanks! |
5 tasks
|
This will not work for all REST endpoints that don't have CORS enabled will it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
I want to be able to test frontend changes on an existing core without having to modify that core's settings.
(not just a development one, production core as well)
I want to avoid the problems I've been experiencing with binding a single folder in two docker containers when using the development flow described for the documentation for the frontend.
Type of change
Added feature to allow building the frontend in such a way that it will connect to a different hassUrl.
Added script to easily start the development build, connect to a core, and host the frontend.
Example configuration
See documentation in script/develop_and_serve
Additional information
I plan to also update the documentation for frontend development to include this option once it has been accepted and included.
Checklist
If user exposed functionality or configuration variables are added/changed: