Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ALL the eslint warnings #23165

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Fix ALL the eslint warnings #23165

merged 4 commits into from
Dec 6, 2024

Conversation

MindFreeze
Copy link
Contributor

Proposed change

662 warnings. Fixed most. Ignored some that made sense.
Tested as much as I could but someone else should also try it out

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Supervisor Related to the supervisor panel Cast Related to Home Assistant Cast UI Design Related to Home Assistant design gallery labels Dec 5, 2024
@bramkragten
Copy link
Member

Now we fixed all the warnings, should we make them errors so we keep it nice and clean? 🙃

@MindFreeze
Copy link
Contributor Author

Now we fixed all the warnings, should we make them errors so we keep it nice and clean? 🙃

yep. I'll do another PR after this

Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@wendevlin wendevlin merged commit 7a12fd2 into dev Dec 6, 2024
15 checks passed
@wendevlin wendevlin deleted the lint_fixes branch December 6, 2024 08:55
@ildar170975 ildar170975 mentioned this pull request Jan 4, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cast Related to Home Assistant Cast UI cla-signed Design Related to Home Assistant design gallery Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants