Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use localStorage with Web Storage API #23172

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

wendevlin
Copy link
Contributor

Proposed change

  • Use localStorage always via the Web Storage API to prevent the pitfalls associated with using plain objects as key-value stores.
  • add tests for
    • common/auth/token_storage
    • util/ha-pref-storage

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin requested a review from bramkragten December 6, 2024 07:27
@github-actions github-actions bot added the Demo Related to frontend demo content label Dec 6, 2024
@wendevlin wendevlin requested a review from bramkragten December 6, 2024 14:57
@bramkragten bramkragten merged commit 8f19c0a into dev Dec 10, 2024
15 checks passed
@bramkragten bramkragten deleted the consistent-local-storage branch December 10, 2024 10:14
boern99 pushed a commit to boern99/ha_frontend that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Demo Related to frontend demo content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants