Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Restore?" option for Timer helpers #23213

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Dec 8, 2024

Proposed change

When creating or editing a Timer helper the option "Restore?" can be ticked by the user:

Screenshot 2024-12-08 19 10 06

This should not be a question but rather just the option itself, and in addition this should better explain its purpose as there is a full line of text possible.

This PR fixes this by adding a similar explanation as for Counter helpers ("Restore the last known value when Home Assistant starts"), following the explanation in the online docs:

Restore state and time when Home Assistant starts

This clearly explains in a few words when this happens and what is restored.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

When creating or editing a Timer helper the option "Restore?" can be ticked by the user.

This should not be a question but rather just the option itself and in addition this should better explain its purpose as there is a full line of text possible.

This commit fixes this by adding a similar explanation as for a Counter helpers, following the explanation in the online docs.
@MindFreeze MindFreeze added the localization Translations and Localization label Dec 9, 2024
Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MindFreeze MindFreeze merged commit 787fba8 into home-assistant:dev Dec 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed localization Translations and Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants