Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for IE 11 and Samsung 4 #23234

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Drop support for IE 11 and Samsung 4 #23234

merged 1 commit into from
Dec 10, 2024

Conversation

steverep
Copy link
Member

Proposed change

The title is kind of a farce because we don't actually currently support IE 11 or Samsung 4 because the web components polyfills are not really loaded properly. In any case, this change adjusts the legacy build to stop transpiling and adding core-js polyfills for them.

These 2 browsers are outside our last 7 years support window, and are only included because of the threshold on usage. But since they are considered dead and won't load the frontend anyway, removing them makes sense. It makes extra sense because the minimum versions of the evergreens have recently passed some critical support milestones, so this drops some of the bigger Babel transforms like async functions, classes, template literals, destructuring, and more, and also knocks off about 120 polyfills from Core JS.

Note the minimums also recently passed the milestones for Brotli support, so I can trade Zopfli for Brotli in this PR as well, but please merge #23233 first.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Build Related to building the code label Dec 10, 2024
This was referenced Dec 10, 2024
@steverep
Copy link
Member Author

750 less modules to bundle,and somehow it ends up with 11 more chunks and a slightly bigger size 😞

@bramkragten bramkragten merged commit 98af479 into dev Dec 10, 2024
16 checks passed
@bramkragten bramkragten deleted the drop-dead-browsers branch December 10, 2024 09:35
boern99 pushed a commit to boern99/ha_frontend that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Related to building the code cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants