Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new script/automation dialog #23253

Closed
wants to merge 1 commit into from
Closed

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 11, 2024

Proposed change

Navigation wasn't working after #23220. I don't know if we have similar issue in other dialog.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon
Copy link
Contributor

silamon commented Dec 11, 2024

Sounds like there may be: #23252 ?

@piitaya
Copy link
Member Author

piitaya commented Dec 11, 2024

Yeah looks like the same issue. When we close a dialog before navigate, we have this issue.

@piitaya piitaya marked this pull request as draft December 11, 2024 09:08
@piitaya
Copy link
Member Author

piitaya commented Dec 11, 2024

Putting it as draft as we may want to fix it in dialog manager.

@piitaya
Copy link
Member Author

piitaya commented Dec 11, 2024

Closing it as it's not the proper way to fix it.

@piitaya piitaya closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants