Fix touch control of chart zoom #23302
Conversation
| @@ -114,7 +114,7 @@ export class StateHistoryChartLine extends LitElement { | |||
| }, | |||
| }, | |||
| min: this.startTime, | |||
| suggestedMax: this.endTime, | |||
| max: this.endTime, | |||
There was a problem hiding this comment.
Why can we no longer use suggestedMax? I think there was a reason we use this instead of max 🤔
There was a problem hiding this comment.
I assume the reason is that we keep adding data and expanding the max, but we also pass through here every time so a hard max has the same effect.
Without hard limits the zoom plugin can break out of the limits while panning
There was a problem hiding this comment.
We have more charts with suggested max, do they all need to be changed? (Like energy charts)
I think what happend was that the point would be on very edge of the graph, causing the label to be cut off or something... Let me check if I can find it
There was a problem hiding this comment.
energy charts already use max. I got the idea from them because I couldn't reproduce the bug there while on more-info it was easy
Proposed change
Allow scrolling over a chart on touch devices when the chart is not zoomed.
Fix a bug where the chart was allowed to pan too much to the right where there is no data.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: