Focus on card search input when adding new card #23309
Merged
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silamon
reviewed
Dec 16, 2024
Co-authored-by: Simon Lamon <32477463+silamon@users.noreply.github.com>
|
Doesn't seem to work |
yeah I fixed it |
MindFreeze
reviewed
Dec 16, 2024
| @@ -120,7 +127,7 @@ export class HuiCreateDialogCard | |||
| .label=${this.hass!.localize( | |||
| "ui.panel.lovelace.editor.cardpicker.by_card" | |||
| )} | |||
| dialogInitialFocus | |||
| dialogInitialFocus=${ifDefined(this._narrow ? "" : undefined)} | |||
There was a problem hiding this comment.
Suggested change
| dialogInitialFocus=${ifDefined(this._narrow ? "" : undefined)} | |
| .dialogInitialFocus=${Boolean(this._narrow)} |
I think this is simpler
There was a problem hiding this comment.
It is not possible, the dialog searches for an attribute, not for a property
| @@ -133,6 +140,7 @@ export class HuiCreateDialogCard | |||
| this._currTabIndex === 0 | |||
| ? html` | |||
| <hui-card-picker | |||
| dialogInitialFocus=${ifDefined(this._narrow ? undefined : "")} | |||
There was a problem hiding this comment.
Suggested change
| dialogInitialFocus=${ifDefined(this._narrow ? undefined : "")} | |
| .dialogInitialFocus=${Boolean(this._narrow)} |
Comment on lines
+69
to
+71
| this._narrow = matchMedia( | ||
| "all and (max-width: 450px), all and (max-height: 500px)" | ||
| ).matches; |
There was a problem hiding this comment.
Side note: we should make this a utility function at some point
MindFreeze
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
None.
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: