Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quotation marks localizable in Add badge dialog #23383

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Dec 22, 2024

Proposed change

Currently the quotation marks in this message are hard-coded:

image

This PR removes them from the code and puts them into the strings file instead for proper localization.
In addition it adds the missing question mark at the end.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Currently the quotation marks are hard-coded. This commit puts them into the strings file and adds the missing question mark at the end.
@NoRi2909 NoRi2909 marked this pull request as ready for review December 22, 2024 18:33
@NoRi2909 NoRi2909 changed the title Add quotation and question marks to en.json for localization Make quotation marks localizable in Add badge dialog Dec 22, 2024
@silamon silamon merged commit a35ba38 into home-assistant:dev Dec 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: Hard-coded quotation marks in Add badge dialog
2 participants