Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom DNS saving #23477

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Fix custom DNS saving #23477

merged 1 commit into from
Dec 27, 2024

Conversation

MindFreeze
Copy link
Contributor

@MindFreeze MindFreeze commented Dec 27, 2024

Proposed change

Nameservers were not sent to core when IP method was auto. Now they will always be sent

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon enabled auto-merge (squash) December 27, 2024 13:50
@silamon silamon merged commit ccbb270 into dev Dec 27, 2024
12 checks passed
@silamon silamon deleted the nameservers branch December 27, 2024 13:50
@silamon silamon added this to the 2025.1 milestone Dec 29, 2024
bramkragten pushed a commit that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not save custom DNS when IPv4 set to Automatic
3 participants