Add ICU strings for proper singular / plural in Search fields #23530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not happen that often that the lists of devices, entities, helpers etc. are filtered down to a single item. But in that case the labels currently use incorrect plural which is more irritating in some languages but also wrong in English. This commit fixes this by adding ICU syntax to all six strings so these work properly in English and all derived translations. For languages that need a different wording for `zero` this also helps translators in extending the ICU syntax for that case.
bramkragten
approved these changes
Jan 6, 2025
bramkragten
pushed a commit
that referenced
this pull request
Jan 6, 2025
It does not happen that often that the lists of devices, entities, helpers etc. are filtered down to a single item. But in that case the labels currently use incorrect plural which is more irritating in some languages but also wrong in English. This commit fixes this by adding ICU syntax to all six strings so these work properly in English and all derived translations. For languages that need a different wording for `zero` this also helps translators in extending the ICU syntax for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
It does not happen that often that the lists of devices, entities, helpers etc. are filtered down to a single item.
But in that case the labels currently use incorrect plural which is more irritating in some languages but also wrong in English:
This PR fixes this by adding ICU syntax to all six strings so these work properly in English and all derived translations.
For languages that need a different wording for
zerothis also helps translators in extending the ICU syntax for that case.Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: