Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media management delete button misalignment #23534

Merged

Conversation

insomniac2305
Copy link
Contributor

Proposed change

The buttons in the media management dialogs were misaligned, as described in issue #17953

Hence this PR changes the slot of the Delete button to navigationIcon to better align it with the Deselect button in the actionItems slot. The result is shown below:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #17953
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @insomniac2305

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Jan 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 1, 2025 16:48
@insomniac2305 insomniac2305 marked this pull request as ready for review January 1, 2025 16:50
Copy link
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bramkragten bramkragten enabled auto-merge (squash) January 2, 2025 14:54
@bramkragten bramkragten added this to the 2025.1 milestone Jan 2, 2025
@bramkragten bramkragten merged commit 15606a5 into home-assistant:dev Jan 2, 2025
14 checks passed
@insomniac2305 insomniac2305 deleted the fix-media-management-alignment branch January 3, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Media management" dialog: misalignment
2 participants