Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore excessive keydown events in charts #24523

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Ignore excessive keydown events in charts #24523

merged 2 commits into from
Mar 6, 2025

Conversation

MindFreeze
Copy link
Contributor

Proposed change

According to #24138 (comment) some systems spam the keydown event while holding the key. This should prevent calling setOption all the time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze added this to the 2025.3 milestone Mar 6, 2025
@bramkragten bramkragten merged commit cdfe4b5 into dev Mar 6, 2025
16 checks passed
@bramkragten bramkragten deleted the chart-zoom-tweak branch March 6, 2025 10:30
@KoalaBear84
Copy link

Thanks @MindFreeze and @bramkragten 👍

bramkragten pushed a commit that referenced this pull request Mar 6, 2025
* Ignore excessive keydown events in charts

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive history graph web browser cpu load: Blocking GUI!
3 participants