Skip to content

Add "created_at" & "modified_at" to "Settings -> Automations" #24767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ildar170975
Copy link
Contributor

@ildar170975 ildar170975 commented Mar 25, 2025

Breaking change

Proposed change

Add "created_at" & "modified_at" to "Settings -> Automations".
(imho only "created" is actually needed, the "modified" changes only when area or icon are changed - and not changed when an automation is changed itself, poor implementation...)

изображение

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review March 25, 2025 04:50
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a good reason that they haven't been added to these: They aren't correct.

The problem is that automations can be managed in different ways, making this data incorrect in some cases. For example, if a script is YAML-managed, this data isn't correct.

This same thing applies to scripts, scenes, and some helpers. This should be addressed in the backend data before the frontend is added.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft March 25, 2025 08:20
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ildar170975
Copy link
Contributor Author

ildar170975 commented Mar 25, 2025

@frenck

There is a good reason that they haven't been added to these: They aren't correct.

Totally agree.
Currently created_at & modified_at show a weather on Mars in most cases.
For yaml-created entities - nothing.
For yaml-created entities with unique ID - work partially.
For UI-created entities - work partially.
For example, chaging an automation in UI does not change modified_at.
As for entities created by some other integrations - BOTH these attributes sometimes change even if I do not touch corresponding config entries.

Tested with tempate sensors, input_boolean, input_number & created issues:
home-assistant/core#123415
home-assistant/core#123420
home-assistant/core#123421
Two of them then were closed by devs as duplicates.
Honestly, as a customer, I see a little movement to fix this situation. Hope I am wrong.

BUT - currently we have created_at & modified_at in Entities.
For consistency - let's add these columns to Automations, Scripts, Helpers.

@ildar170975 ildar170975 marked this pull request as ready for review March 25, 2025 14:36
@home-assistant home-assistant bot requested a review from frenck March 25, 2025 14:36
@frenck
Copy link
Member

frenck commented Mar 25, 2025

Moving this back to draft:

This should be addressed in the backend data before the frontend is added.

../Frenck

@frenck frenck marked this pull request as draft March 25, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants