-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Clean up polymer paper item CSS variables #24896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @silamon, It seems that I integrate this changes here: |
The remaining diff became much smaller, I would still merge for the removed code on 2 places, but I'm not sure if the defaults state color items are needed. |
"paper-listbox-background-color": "var(--card-background-color)", | ||
"paper-item-icon-active-color": "var(--state-icon-active-color)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
These are also used in the demo themes. Please remove it there too
Breaking change
--paper-item-icon-active-color
--paper-listbox-background-color
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: