Skip to content

Clean up polymer paper item CSS variables #24896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 25, 2025

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Apr 2, 2025

Breaking change

  • Css theme vars removed:
    • --paper-item-icon-active-color
    • --paper-listbox-background-color

Proposed change

  • Removals without replacements are dead code

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added Supervisor Related to the supervisor panel Design Related to Home Assistant design gallery labels Apr 2, 2025
@bramkragten bramkragten requested a review from wendevlin April 24, 2025 14:45
@wendevlin
Copy link
Contributor

Hey @silamon,
Can you update your branch and check if this PR is still needed?

It seems that I integrate this changes here:

@github-actions github-actions bot removed Supervisor Related to the supervisor panel Design Related to Home Assistant design gallery labels Apr 24, 2025
@silamon
Copy link
Contributor Author

silamon commented Apr 24, 2025

Hey @silamon, Can you update your branch and check if this PR is still needed?

It seems that I integrate this changes here:

The remaining diff became much smaller, I would still merge for the removed code on 2 places, but I'm not sure if the defaults state color items are needed.

@bramkragten bramkragten added the Breaking Change Needs Special Documentation to let users know about Change label Apr 24, 2025
Comment on lines -181 to -182
"paper-listbox-background-color": "var(--card-background-color)",
"paper-item-icon-active-color": "var(--state-icon-active-color)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

These are also used in the demo themes. Please remove it there too

@github-actions github-actions bot added Supervisor Related to the supervisor panel Demo Related to frontend demo content labels Apr 25, 2025
@silamon silamon changed the title Replace polymer paper item CSS variables Clean up polymer paper item CSS variables Apr 25, 2025
@bramkragten bramkragten merged commit c7ca654 into home-assistant:dev Apr 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Needs Special Documentation to let users know about Change cla-signed Demo Related to frontend demo content Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants