Fix more info weather card - errant semi colon and zero degrees not displaying #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The temperature is mandatory and therefore not checked. |
bramkragten
approved these changes
Nov 18, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted here: https://community.home-assistant.io/t/support-for-environment-canada-platforms/126241/88
In more-info when using daily, there was an errant semi colon in between the low temperature and high temperature. Also, the conditional statements for each display value could evaluate to false when numerically equal to zero. Therefore showing nothing.
With these changes, it looks like this
As a question, temperature (in current observation and the high temperature) is not checked, but always shown. Is it a problem if the temperature is None? I assume it is okay as is, but will show a blank temperature. I'm not a frontend native developer, so I'm not sure.