Fix actions not working on touch devices #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
iantrich
reviewed
Nov 18, 2019
| @@ -193,7 +191,7 @@ class ActionHandler extends HTMLElement implements ActionHandler { | |||
|
|
|||
| customElements.define("action-handler", ActionHandler); | |||
|
|
|||
| const geActionHandler = (): ActionHandler => { | |||
| const getActionHandler = (): ActionHandler => { | |||
iantrich
reviewed
Nov 18, 2019
| this.timer = window.setTimeout(() => { | ||
| this.startAnimation(x, y); | ||
| this.held = true; | ||
| }, this.holdTime); |
There was a problem hiding this comment.
I remember we discussed this somewhat; something to do with not wanting to show the ripple if there was no hold action set
There was a problem hiding this comment.
Yeah I still think this is not necessary when there is no hold action, but I also know @thomasloven had a lot of trouble getting this to work on all devices, so was not going to experiment 2 days before the release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4230