Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fixes #5634

Merged
merged 6 commits into from
Apr 26, 2020
Merged

Translation fixes #5634

merged 6 commits into from
Apr 26, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 26, 2020

Breaking change

Proposed change

So I realized that sprinkling the code with __BACKWARDS_COMPAT__ wherever we load translations of states is going to get old really fast and we'll probably miss ones.

So instead I went the other way around: for builds that do not have access to the backend or that will potentially connect to older backends (cast), we merge in a copy of the backend state translations.

Backend translations are created using a new addition to the core repo translations script.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 7c6ba1a into dev Apr 26, 2020
@bramkragten bramkragten deleted the translation-fixes branch April 26, 2020 19:09
@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants