Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height of card picker #6274

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Fix height of card picker #6274

merged 3 commits into from
Jun 29, 2020

Conversation

bramkragten
Copy link
Member

Proposed change

Still not perfect as it now keeps the scrollbars while searching, but it stays full-size and doesn't jump...

To do it properly we should set the height on the dialog itself instead of on the containing div, or move the overflow to the div...

Fixes #6231

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten reopened this Jun 29, 2020
@bramkragten bramkragten requested a review from balloob June 29, 2020 16:35
@balloob balloob merged commit 31a0c53 into dev Jun 29, 2020
@balloob balloob deleted the fix-height-card-picker branch June 29, 2020 20:18
@balloob balloob mentioned this pull request Jun 29, 2020
yosilevy pushed a commit to yosilevy/home-assistant-polymer that referenced this pull request Jul 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card Picker dialog height small on 0.112.0b0
3 participants