-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate fan speeds into percentages and presets modes #8216
Conversation
Having seen the UI - wondering if we need to support some kind of "step size"? Otherwise this could be an annoying UI for fans that genuinely only do have 3 speeds. For dyson we could set this to 10, and for homekit_controller we could read it off the characteristic metadata too. Is that something thats possible? |
I think it's doable but I'm not sure what to do with the ones with 7 speeds and a step size of 14.28. Also for zwave and isy we wouldn't know the step size in advance. Maybe something we can add later if we find we really need it since it won't require any refactoring in the entity model, just a new property? (I'm starting to get a bit nervous about scope and the size of the core PR) Edit: I did some testing and step size should be relatively clear to do this later, and it should make the homekit experience a bit cleaner. For backwards compat we would default to a step size of 1 |
Marking as draft until the |
Retested. All seems ok 👍 |
Breaking change
Fans now use a percentage slider for speeds and a dropdown for preset modes.
Proposed change
Core: home-assistant/core#45407
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: