Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop margin from cast header #8331

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Drop margin from cast header #8331

merged 2 commits into from
Feb 6, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 5, 2021

Breaking change

Proposed change

Drop the margin because now we did margin + padding, which was incorrect.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

You should also fix the border radius on the hero ;-)

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@balloob balloob merged commit 9c7af0d into dev Feb 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the cast-header-margin branch February 6, 2021 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants