Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing choose actions if default path chosen and other things #8779

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 1, 2021

Breaking change

Proposed change

  • Show default sequence of a choose in the timeline
  • Describe service actions in timeline

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob changed the title Fix showing choose actions if default path chosen Fix showing choose actions if default path chosen and other things Apr 1, 2021
@@ -0,0 +1 @@
export const isDynamicTemplate = (value: string) => value.includes("{{");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Yeah.

@bramkragten bramkragten merged commit 5c1604e into dev Apr 1, 2021
@bramkragten bramkragten deleted the fixes-tracing branch April 1, 2021 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants