Improve ensureArray and use it in tracing #8785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Apr 1, 2021
src/common/ensure-array.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| export const ensureArray = (value?: any) => { | |||
| export const ensureArray = <T>(value: T | T[]): T[] => { | |||
| if (!value || Array.isArray(value)) { | |||
There was a problem hiding this comment.
!value is not correct here if the param no longer can be undefined ?
balloob
reviewed
Apr 1, 2021
| ? this.trace.config.condition | ||
| : [this.trace.config.condition] | ||
| )?.map((condition, i) => this.render_condition(condition, i))} | ||
| ${ensureArray(this.trace.config.condition)?.map((condition, i) => |
There was a problem hiding this comment.
You can see that I'm rusty in frontend work :)
balloob
approved these changes
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: