Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve keyboard nav #8794

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Improve keyboard nav #8794

merged 1 commit into from
Apr 1, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 1, 2021

Breaking change

Proposed change

Improve keyboard nav for the tracing UI. The only thing that's still not ideal is that the graph will focus the next element when tabbing through it. Is this on purpose @thomasloven? It makes it impossible to use just the keyboard and the graph to browse some details of a step. It's still possible right now via the arrow buttons that come after the graph.

Screenshot.2021-04-01.at.14.51.09.mp4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 3341967 into dev Apr 1, 2021
@bramkragten bramkragten deleted the keyboard-nav branch April 1, 2021 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2021
@thomasloven
Copy link
Contributor

It was added as an accessibility feature that I later realized 1000% missed the goal and actually hurts accessibility for exactly this reason.
It's not trivial to remove, unfortunately, but I'll get on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants