Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CarPlay Entities update logic #2527

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 17, 2024

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Comparison is base (ca0313d) 27.54% compared to head (0f381ee) 27.47%.
Report is 1 commits behind head on master.

Files Patch % Lines
...cle/Templates/Actions/CarPlayActionsTemplate.swift 0.00% 34 Missing ⚠️
...plates/Entities/CarPlayEntitiesListViewModel.swift 0.00% 32 Missing ⚠️
...Templates/Domains/CarPlayDomainsListTemplate.swift 0.00% 23 Missing ⚠️
...es/App/Settings/SettingsDetailViewController.swift 0.00% 18 Missing ⚠️
...cle/Templates/Entities/CarPlayEntityListItem.swift 0.00% 18 Missing ⚠️
...le/Templates/Actions/CarPlayActionsViewModel.swift 0.00% 17 Missing ⚠️
...ources/App/Notifications/NotificationManager.swift 0.00% 16 Missing ⚠️
...mplates/Entities/CarPlayEntitiesListTemplate.swift 0.00% 8 Missing ⚠️
Sources/App/Settings/SettingsRootDataSource.swift 0.00% 4 Missing ⚠️
...emplates/Domains/CarPlayDomainsListViewModel.swift 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2527      +/-   ##
==========================================
- Coverage   27.54%   27.47%   -0.07%     
==========================================
  Files         308      309       +1     
  Lines       31419    31497      +78     
==========================================
  Hits         8655     8655              
- Misses      22764    22842      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit cef9934 into master Jan 18, 2024
8 checks passed
@bgoncal bgoncal deleted the carplay-entities-update-fix branch January 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants