Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to CarPlay Areas and Actions tabs #2543

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 25, 2024

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest January 25, 2024 10:09
@bgoncal bgoncal self-assigned this Jan 25, 2024
@bgoncal bgoncal changed the title Add pagination to CarPlay Areas tab Add pagination to CarPlay Areas and Actions tabs Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 169 lines in your changes are missing coverage. Please review.

Comparison is base (cef9934) 27.54% compared to head (16416dd) 27.54%.
Report is 9 commits behind head on master.

Files Patch % Lines
...hicle/Templates/CarPlayPaginatedListTemplate.swift 0.00% 35 Missing ⚠️
Sources/App/Settings/ActionConfigurator.swift 0.00% 29 Missing ⚠️
Sources/App/Scenes/WindowSizeObserver.swift 36.11% 23 Missing ⚠️
Sources/App/Scenes/WindowScenesManager.swift 65.51% 20 Missing ⚠️
Sources/Shared/API/Models/Action.swift 11.11% 16 Missing ⚠️
...cle/Templates/Actions/CarPlayActionsTemplate.swift 0.00% 12 Missing ⚠️
...hared/Common/Extensions/Realm+Initialization.swift 0.00% 9 Missing ⚠️
...le/Templates/Areas/CarPlayAreasZonesTemplate.swift 0.00% 6 Missing ⚠️
Sources/Vehicle/Templates/HAEntity+CarPlay.swift 0.00% 5 Missing ⚠️
Sources/App/Scenes/WebViewSceneDelegate.swift 50.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2543      +/-   ##
==========================================
- Coverage   27.54%   27.54%   -0.01%     
==========================================
  Files         309      311       +2     
  Lines       31472    31681     +209     
==========================================
+ Hits         8668     8725      +57     
- Misses      22804    22956     +152     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

emerge-tools bot commented Jan 30, 2024

1 build increased size

Name Version Download Change Install Change
Home Assistant
io.robbie.HomeAssistant
2024.2 (2024.3020) 43.9 MB ⬆️ 202.9 kB (0.46%) 92.3 MB ⬆️ 285.9 kB (0.32%)

Home Assistant 2024.2 (2024.3020)
io.robbie.HomeAssistant

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 285.9 kB (0.32%)
Total download size change: ⬆️ 202.9 kB (0.46%)

Largest size changes

Item Install Size Change
📝 Apple_Watch_App_Icon.png ⬆️ 99.6 kB
ha-logo-round.pdf ⬆️ 0 B
ha-logo-black (2).pdf ⬆️ 0 B
📝 Other ⬆️ 14.8 kB
Other ⬆️ 3.4 kB

Image of diff


🛸 Powered by Emerge Tools

@bgoncal bgoncal merged commit f44bf39 into master Jan 30, 2024
8 checks passed
@bgoncal bgoncal deleted the carplay-areas-pagination branch January 30, 2024 13:26
@bgoncal bgoncal mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants