Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define dark and tinted variants for some custom icons #2967

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Sep 2, 2024

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Sep 2, 2024
Copy link

emerge-tools bot commented Sep 2, 2024

1 build increased size

Name Version Download Change Install Change Approval
⚠️ Home Assistant
io.robbie.HomeAssistant
2024.9 (2024.3797) 58.0 MB ⬆️ 6.3 MB (12.23%) 123.3 MB ⬆️ 6.4 MB (5.54%) N/A

Home Assistant 2024.9 (2024.3797)
io.robbie.HomeAssistant

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 6.4 MB (5.54%)
Total download size change: ⬆️ 6.3 MB (12.23%)

Largest size changes

Item Install Size Change
Color=Dev_1024pt@1x.png ⬆️ 1.7 MB
dev-1024x1024.png ⬆️ 1.7 MB
Color=Pride - Rainbow Flag_1024pt@1x.png ⬆️ 655.2 kB
📝 Icon-Tinted-1024x1-24.png ⬆️ 0 B
Color=Pride - Trans Flag_1024pt@1x.png ⬆️ 572.4 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@bgoncal
Copy link
Member Author

bgoncal commented Sep 2, 2024

Removed duplicate icons but tinted versions need to be separate files (even though they are the same), tried symlink and it does not work either, xcode recreates asset file.

@bgoncal bgoncal requested a review from a team September 2, 2024 13:10
@bgoncal bgoncal merged commit 9431cec into master Sep 2, 2024
5 checks passed
@bgoncal bgoncal deleted the ios18-custom-icons branch September 2, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant