Fixing weather_HassGetWeather and person_HassGetState #1768
Replies: 8 comments 17 replies
-
|
will do so today evening (CET) for German language -> Done #1777 |
Beta Was this translation helpful? Give feedback.
-
|
ok ... just to be sure, so we need to rebase #1657 onto untranslated-state, than going to merge into untranslated-state, afterwards go ahead with adopting #1767 for German language? |
Beta Was this translation helpful? Give feedback.
-
|
rebase and merge is done, now going ahead with adopting #1767 for German language |
Beta Was this translation helpful? Give feedback.
-
|
That's the game plan, yes. I mean... the point is to have these features available on the |
Beta Was this translation helpful? Give feedback.
-
|
Done #1777 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks! When the checks are done, you can merge it to the feature branch |
Beta Was this translation helpful? Give feedback.
-
|
@tetele Do you want us to do it ASAP or are you expecting any further changes to the #1767 and we should wait for it to be finalized and merged? |
Beta Was this translation helpful? Give feedback.
-
|
I'm not planning any changes, but I would like to get @synesthesiam's review before merging. I think the fastest approach is to translate the current changes and subscribe to any reviews for #1767 to see if there will be any updates. I haven't got Mike's confirmation on pushing a new intents release, so I can't guarantee we will have a new release tomorrow, but I hope we will be able to. Also, keep in mind you don't have to make these changes, it was just that I thought the stream would drive some adoption and testing and it would have been better if stuff worked :D |
Beta Was this translation helpful? Give feedback.
-
|
There's your answer. No further changes, your honor! :D |
Beta Was this translation helpful? Give feedback.
-
|
@tetele PR is ready #1779 I was also forced to do whole lot more than just what was in scope if this discussion (details in the PR description). Sorry for all the people that got notified that a new PR with their language label was created, when PR was just in draft mode I've had it target branch set to |
Beta Was this translation helpful? Give feedback.
-
|
Hi @tetele, any ETA on when you'll fix the the "small hiccup" in home-assistant/core#105524 so we can merge the https://github.com/home-assistant/intents/tree/untranslated-state back into main? Thank you. |
Beta Was this translation helpful? Give feedback.
-
|
You'll need to ask @synesthesiam about that. Apparently, it's not necessarily the preferred approach, although usable. Mike said that he would make the changes himself (without providing a timeline), but I haven't seen him online in a while. The initial idea was for this change to be included in Chapter 5, but no release was made specifically for it. Anyway, long story short, no, I don't have an ETA. The |
Beta Was this translation helpful? Give feedback.
-
|
Spanish changes completed, waiting for home-assistant/core#105524. |
Beta Was this translation helpful? Give feedback.
-
|
NL done as well #1771 |
Beta Was this translation helpful? Give feedback.
-
|
PR's are approved and waiting to be merged. One small hiccup in the HA core PR, but it will be fixed soon. Please proceed with the changes :) |
Beta Was this translation helpful? Give feedback.
-
|
PT-BR done #1786 |
Beta Was this translation helpful? Give feedback.
-
|
@jmceara bummer, there's no language leader for Brazilian Portuguese. Wanna fill in those shoes? It's not a hard job, but we would hate to see you ignore it. |
Beta Was this translation helpful? Give feedback.
-
|
Let's go! :) |
Beta Was this translation helpful? Give feedback.
-
|
@synesthesiam please see #1786 (which accounts as at least a few PRs) and anoint @jmceara as knight of the language leaders if you so see fit. |
Beta Was this translation helpful? Give feedback.
-
|
I was about to create a PR for pt-br translations when I found the existing ones and this topic. So, count me in to help @jmceara. |
Beta Was this translation helpful? Give feedback.
-
|
Catalan [CA] done at #1787 |
Beta Was this translation helpful? Give feedback.
-
|
I've added a review and asked for a small change. It's true it was not clear in English which is the state and which is the translation |
Beta Was this translation helpful? Give feedback.
-
|
I will try to get Danish (DA) done tonight. |
Beta Was this translation helpful? Give feedback.
-
Hey @home-assistant/language-leaders!
You might have noticed in a production environment that the
weather_HassGetWeatherintent doesn't really work (it doesn't provide the weather condition) and that theperson_HassGetStateintent is really hit and miss.The reason behind this is that both intents use the state value for making decisions upon which to build the response, but the state is translated before being used in the intent response. This is by design, as you want to say that a battery "isn't on, but off" in the same language in which the question was received.
Since we're less than 36h away from the Chapter 5 stream, I was going to propose we fix the sentences for
weatherandpersonstate in the short time we have until then, so that people can enjoy the functionality as soon as possible.To prevent breaking changes, I've made a core PR that introduces both the translated and untranslated state as state attributes, thus preserving the current translated state behavior. The PR is still under review, though, so I wouldn't recommend that you fix the sentences/responses/tests directly on the
mainbranch of the intents repo. Instead, I've created anuntranslated-statebranch, upon which I've opened a PR to fix the English sentences.This PR is also pending review and I'd recommend you subscribe to it to get notifications in case anything changes.The PR has been approved and merged, so it's a good example of what needs to be doneI kindly ask you to do the same for the languages you are leading as I did for English:
untranslated-branchin your fork:git fetch upstream untranslated-state, assuming the remote pointing tohome-assistant/intentsis calledupstreamgit checkout untranslated-stategit branch xx-untranslated-changeswherexxcould be a language code. Feel free to name your branch however you want, thoughuntranslated-statebranch by using a URL similar to this untranslated-state...your-name:intents:xx-untranslated-state (you need to edit the URL to make it work)untranslated-statebranch as soon as yousee [EN] Fix intents with untranslated state #1767 being merged (changes may still occur)canOnce home-assistant/core#105524 gets merged into
core, we can also merge the new branch into the intents repo and create a new release. That way, we will sync our effort and not introduce breaking changes.Beta Was this translation helpful? Give feedback.
All reactions